Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: at_auth package #428

Merged
merged 6 commits into from
Oct 13, 2023
Merged

feat: at_auth package #428

merged 6 commits into from
Oct 13, 2023

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Oct 13, 2023 •
edited
Loading

- What I did

  • Added a new package at_auth which will have onboard and authentication logic
  • The new package will help to eliminate code duplication in at_onboarding_cli and at_client_mobile

- How I did it

  • added at_auth_base.dart interface which has onboard and authenticate methods
  • Introduced request and response objects for onboard (AtOnboardingRequest/AtOnboardingResponse) and authenticate(AtAuthRequest/AtAuthResponse)
  • Implemented separate classes for cram(CramAuthenticator) and pkam auth(PkamAuthenticator)
  • Implemented onboard and authenticate methods in AtAuthImpl
  • Added unit tests

- How to verify it

  • run the unit tests
  • uptake the new package changes in at_onboarding_cli and run unit/functional tests

@murali-shris murali-shris merged commit a630055 into trunk Oct 13, 2023
@murali-shris murali-shris deleted the at_auth_new branch October 13, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murali-shris @gkc