Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue 586 #611

Merged
merged 11 commits into from
Jul 19, 2024
Merged

fix: fix issue 586 #611

merged 11 commits into from
Jul 19, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Jul 17, 2024

- What I did
Resolve #586

- How I did it
See commits

- How to verify it
Tests pass

@gkc gkc requested review from srieteja and murali-shris July 18, 2024 12:49
@gkc gkc marked this pull request as ready for review July 18, 2024 12:50
- add a new main which calls wrappedMain and exits with wrappedMain's return code
- call activate_cli.wrappedMain instead of activate_cli.main from at_onboarding_cli_test.dart and register.dart
@gkc gkc merged commit 4477275 into trunk Jul 19, 2024
11 checks passed
@gkc gkc deleted the fix-586 branch July 19, 2024 08:56
@gkc gkc mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional test failing, but github job doesn't fail
2 participants