fix: APKAM keys expiry feature changes in at_commons #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitaram-kalluri
force-pushed
the
2074-auto_expiry_at_commons_changes
branch
from
9bec1f6 to
02eb8ca
Compare
murali-shris
requested changes
Sep 13, 2024
| @@ -44,6 +44,8 @@ class EnrollVerbBuilder extends AbstractVerbBuilder { | |||
| /// Accepts a list of enrollment statuses. Defaults to all EnrollmentStatuses | |||
| List<EnrollmentStatus>? enrollmentStatusFilter; | |||
|
|
|||
| Duration? apkamKeysExpiryDuration; | |||
There was a problem hiding this comment.
please add a test in enroll verb builder for this param
murali-shris
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did