feat: add 'auto' approve feature to auth_cli #685
Conversation
…has been superseded by src/cli/auth_cli.dart
Also: - fix: standardized the AtClient storage path used in the auth_cli - refactor: deprecate the old src/activate_cli/activate_cli.dart as it has been superseded by src/cli/auth_cli.dart
…into feat-auth-cli-add-auto-approve
|
#687 has been merged and published and the at_cli_commons dependency has been upgraded to ^1.2.0 |
| @@ -6,11 +6,13 @@ import 'package:at_onboarding_cli/at_onboarding_cli.dart'; | |||
| import 'package:at_onboarding_cli/src/util/at_onboarding_exceptions.dart'; | |||
There was a problem hiding this comment.
this file is deprecated as all functionality is now in cli/auth_cli.dart
| @@ -20,10 +21,25 @@ final AtSignLogger logger = AtSignLogger(' CLI '); | |||
|
|
|||
| final aca = AuthCliArgs(); | |||
|
|
|||
There was a problem hiding this comment.
We now create ephemeral storage each time; we clean it up when we exit
| } | ||
| } | ||
|
|
||
| Future<int> _main(List<String> arguments) async { | ||
| Future<int> wrappedMain(List<String> arguments) async { |
There was a problem hiding this comment.
made public so that it can be called by the at_onboarding_cli_test in at_onboarding_cli_functional_tests
| String nameSpace = 'at_auth_cli'; | ||
| if (storageDir != null) { | ||
| throw StateError('AtClient has already been created'); | ||
| } |
There was a problem hiding this comment.
Just a check to ensure we don't have a logic error elsewhere
| progName: nameSpace, | ||
| uniqueID: '${DateTime.now().millisecondsSinceEpoch}', | ||
| ); | ||
|
|
There was a problem hiding this comment.
Using the utility function newly added to at_cli_commons 1.2.0
| @@ -650,7 +684,8 @@ Future<Map> _fetchOrListAndFilter( | |||
| return enrollmentMap; | |||
| } | |||
|
|
|||
| Future<void> approve(ArgResults ar, AtClient atClient) async { | |||
| Future<int> approve(ArgResults ar, AtClient atClient, {int? limit}) async { | |||
| int approved = 0; | |||
There was a problem hiding this comment.
Added an optional limit parameter and track and return an approved count so that we can also call this function from the autoApprove function when required
|
|
||
| if (limit != null && approved >= limit) { | ||
| return approved; | ||
| } |
There was a problem hiding this comment.
If we were passed a limit parameter (e.g. by the autoApprove function) then let's respect it
| return approved; | ||
| } | ||
|
|
||
| Future<int> autoApprove(ArgResults ar, AtClient atClient) async { |
There was a problem hiding this comment.
New feature.
- if requested, calls
approveto approve any existing matching enrollment requests, and respecting the approval count limit while doing so - listen for new enrollment request notifications
- when one is received, and it matches the supplied regex filter(s), then
- approve it
- check the approved count vs limit
- if limit has been reached
- complete the completer so the
await completer.futurecompletes - clean up the subscription
- complete the completer so the
| '-c', | ||
| params['cramkey']!, | ||
| ], | ||
| ); |
There was a problem hiding this comment.
as mentioned earlier, activate_cli.dart has been deprecated as it has been entirely replaced by auth_cli.dart
- What I did
- How I did it
See commits
- How to verify it
Tests pass