fix: at_commons remove isPaginated check in sync verb builder #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murali-shris
changed the title
murali-shris
requested review from
gkc,
srieteja and
sitaram-kalluri
and removed request for
srieteja
srieteja
previously approved these changes
Dec 11, 2024
gkc
requested changes
Dec 12, 2024
There was a problem hiding this comment.
@murali-shris I know in the other comment I said a PR in at_lookup to change SyncVerbBuilder but I meant a PR in at_commons since SyncVerbBuilder is in at_commons
murali-shris
changed the title
Completed the changes. |
gkc
requested changes
Dec 12, 2024
gkc
approved these changes
Dec 16, 2024
| if (isPaginated) { | ||
| serverCommandBuffer.write('from:'); | ||
| } | ||
| // removed isPaginated logic, since sync:from is the default sync verb on server |
There was a problem hiding this comment.
Don't need this comment in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
fix: remove sync verb builder deprecated params at_client_sdk#1450