New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: at_lookup - flush socket after write and rethrow any exceptions … #747

Open

sitaram-kalluri wants to merge 1 commit into trunk from 716-exception-handling-in-at_lookups-baseconnectionwrite

Member

sitaram-kalluri commented Dec 20, 2024 •

edited

Loading

- What I did

In at_lookup, connection.dart :
- call socket.flush() after socket.write()
- Rethrow the exception from the write method.

- How to verify it

Created a draft PR in at_client pointing to this at_lookup commit and run all functional and E2E tests. All tests passed
All the functional tests in the at_onboarding_cli passed.

- Description for the changelog

fix: at_lookup - flush socket after write and rethrow any exceptions


          fix: at_lookup - flush socket after write and rethrow any exceptions …

d03f69b

…occurred

sitaram-kalluri requested review from murali-shris and gkc

December 20, 2024 11:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet