test: removed unnecessary TODOS; updated config12.yaml adding connect…

…ion type `websocket`
atsign-foundation · Dec 12, 2024 · 7a62b0e · 7a62b0e
1 parent cc2ce8d
commit 7a62b0e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/at_server.yaml b/.github/workflows/at_server.yaml
@@ -569,11 +569,9 @@ jobs:
               sed -i "s/ATSIGN_1_NAME/@$AT_SIGN_1/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml
               sed -i "s/ATSIGN_1_PORT/$AT_SIGN_1_PORT/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml
               sed -i "s/ATSIGN_1_HOST/$AT_SIGN_1_HOST/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml
-              # TODO: add something like sed -i "s/ATSIGN_1_CONNECTION_TYPE/$AT_SIGN_1_CONNECTION_TYPE/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml
               sed -i "s/ATSIGN_2_NAME/@$AT_SIGN_2/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml
               sed -i "s/ATSIGN_2_PORT/$AT_SIGN_2_PORT/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml
-              sed -i "s/ATSIGN_2_HOST/$AT_SIGN_2_HOST/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml
-              # TODO: add something like sed -i "s/ATSIGN_2_CONNECTION_TYPE/$AT_SIGN_2_CONNECTION_TYPE/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml
+              sed -i "s/ATSIGN_2_HOST/$AT_SIGN_2_HOST/g" tests/at_end2end_test/config/config-e2e_test_runtime.yaml  
               mv tests/at_end2end_test/config/config-e2e_test_runtime.yaml tests/at_end2end_test/config/config.yaml                       
               cat tests/at_end2end_test/config/config.yaml 
               echo "Connection successful"

diff --git a/tests/at_end2end_test/config/config12.yaml b/tests/at_end2end_test/config/config12.yaml
@@ -8,14 +8,18 @@ root_server:
 # cicd atsign details
 first_atsign_server:
   first_atsign_name: '@cicd1'
-  # # The port to connect to first atsign server
+  # The port to connect to first atsign server
   first_atsign_port: 6464
-  # # The url to connect to first atsign server
+  # The url to connect to first atsign server
   first_atsign_url: cicd1.atsign.wtf
+  # The type of connection (socket or websocket)
+  first_atsign_connection_type: websocket
 
 second_atsign_server:
   second_atsign_name: '@cicd2'
-  # # The port to connect to second atsign server
+  # The port to connect to second atsign server
   second_atsign_port: 6464
-  # # The url to connect to second atsign server
+  # The url to connect to second atsign server
   second_atsign_url: cicd2.atsign.wtf
+  # The type of connection (socket or websocket)
+  second_atsign_connection_type: websocket