Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync verb builder limit param from client is not used in SyncProgressiveVerbHandler #2181

Closed
murali-shris opened this issue Dec 13, 2024 · 0 comments · Fixed by #2182
Closed
Assignees
Labels
bug Something isn't working

Comments

@murali-shris
Copy link
Member

Describe the bug

In SyncProgressiveVerbHandler, only fromCommitSequence and regex are read from verb params. limit is not read. Call to atCommitLog.getEntries(...) uses default value 25 for limit.

Steps to reproduce

n/a

Expected behavior

If client passes limit, read the limit from verb params and pass it to atCommitLog.getEntries(...)

Screenshots

No response

Smartphones

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Were you using an atApplication when the bug was found?

No response

Additional context

No response

@murali-shris murali-shris added the bug Something isn't working label Dec 13, 2024
@murali-shris murali-shris self-assigned this Dec 13, 2024
@gkc gkc closed this as completed in #2182 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant