Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sync verb handler add limit param #2182

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Dec 13, 2024

Fixes #2181
- What I did

  • Use limit param set from sync verb builder on client side in sync verb handler
    - How I did it
  • read limit param in SyncProgressiveVerb handler and pass it to commitLog.getEntries(..) call
  • prepare response method was using SecondaryConfig.pageLimit . Modified this method to use passed syncLimit
  • added unit tests
    - How to verify it
  • tests should pass

@murali-shris murali-shris marked this pull request as ready for review December 16, 2024 11:28
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test(s) to cover this

@murali-shris
Copy link
Member Author

Please add unit test(s) to cover this

done

@murali-shris murali-shris requested a review from gkc December 17, 2024 07:03
@gkc gkc merged commit a5fb9b5 into trunk Dec 17, 2024
26 checks passed
@gkc gkc deleted the sync_verb_handler_add_limit_param branch December 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync verb builder limit param from client is not used in SyncProgressiveVerbHandler
2 participants