-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: server events web hook #1435
Draft
gkc
wants to merge
14
commits into
trunk
Choose a base branch
from
gkc-telemetry-web-hook
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient-to-server interactions, server-to-server interactions) to a configured web-hook, if any
# Conflicts: # packages/at_secondary_server/lib/src/connection/inbound/inbound_connection_impl.dart # packages/at_secondary_server/lib/src/connection/inbound/inbound_message_listener.dart # packages/at_secondary_server/lib/src/server/at_secondary_impl.dart # packages/at_secondary_server/lib/src/verb/handler/config_verb_handler.dart
…'runtime' directory if it doesn't exist already
# Conflicts: # packages/at_secondary_server/pubspec.yaml # tools/run_locally/scripts/macos/at_server
…roadcastConfigChange since (a) we now have configs that may be set on non-testing-mode servers and (b) the guard, to prevent configs which require testingMode being set when testingMode is not enabled, has been added to the ConfigVerbHandler refactor: moved the telemetry initialization code into one method in AtSecondaryServerImpl chore: updated pubspec to require later version of dart sdk because we are using the enhanced enums feature for the ModifiableConfigs enum
…ry event webHook uri
test: Fixed config verb tests
# Conflicts: # packages/at_secondary_server/lib/src/connection/inbound/inbound_connection_impl.dart # packages/at_secondary_server/lib/src/server/at_secondary_config.dart # packages/at_secondary_server/lib/src/verb/handler/config_verb_handler.dart # packages/at_secondary_server/lib/src/verb/handler/lookup_verb_handler.dart
style: enhance log messages style: use `super` syntax for constructor parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
config:set:telemetryEventWebHook=https://your.domain.testing.zone/hook
config:reset:telemetryEventWebHook
config:print:telemetryEventWebHook
subscribe
andbroadcastConfigChange
methods since- How to verify it
All tests should pass