Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new expiry logic and error codes for enrollments #1536

Merged
merged 30 commits into from
Sep 12, 2023
Merged

fix: new expiry logic and error codes for enrollments #1536

merged 30 commits into from
Sep 12, 2023

Conversation

srieteja
Copy link
Contributor

@srieteja srieteja commented Sep 5, 2023 •
edited
Loading

- What I did

  • Exclude expired enrollments from enroll:list
  • Specific errorCode and errorMessage when approving, revoking, denying expired enrollment
  • ErrorCode and message when authenticating using an expired enrollment

- How to verify it

  • existing tests concerning expired tests have been updated to match the current changes

@srieteja srieteja self-assigned this Sep 5, 2023
@srieteja srieteja marked this pull request as draft September 5, 2023 09:20
@murali-shris
Copy link
Member

let's use AtMetaData.expiresAt to check whether enrollment has expired instead of introducing new expiresAt in EnrollDataStoreValue

@srieteja srieteja marked this pull request as ready for review September 7, 2023 05:30
murali-shris
murali-shris requested changes Sep 7, 2023
View reviewed changes
packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart Outdated Show resolved Hide resolved
packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart Outdated Show resolved Hide resolved
packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart Outdated Show resolved Hide resolved
packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart Outdated Show resolved Hide resolved
packages/at_secondary_server/lib/src/verb/handler/pkam_verb_handler.dart Outdated Show resolved Hide resolved
packages/at_secondary_server/lib/src/verb/handler/pkam_verb_handler.dart Outdated Show resolved Hide resolved
packages/at_secondary_server/pubspec.yaml Outdated Show resolved Hide resolved
packages/at_secondary_server/lib/src/verb/handler/enroll_verb_handler.dart Outdated Show resolved Hide resolved
Base automatically changed from auto_expire_enroll_key to trunk September 8, 2023 05:31
@sitaram-kalluri
Copy link
Member

@srieteja : Please fix the failing unit tests

sitaram-kalluri
sitaram-kalluri requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@sitaram-kalluri sitaram-kalluri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the unit tests

@srieteja
fix: rename verifyEnrollmentStateBeforeAction -> verifyEnrollmentStat…
2ce1820 
…e and merge validateEnrollmentValidity() into parent
@murali-shris murali-shris merged commit 68517d3 into trunk Sep 12, 2023
17 checks passed
@murali-shris murali-shris deleted the nwe_expire_logic branch September 12, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murali-shris murali-shris murali-shris approved these changes

@sitaram-kalluri sitaram-kalluri sitaram-kalluri left review comments

Assignees

@srieteja srieteja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srieteja @murali-shris @sitaram-kalluri