Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement AtRateLimiter spec changes #1548

Merged
merged 2 commits into from
Sep 12, 2023
Merged

feat: Implement AtRateLimiter spec changes #1548

merged 2 commits into from
Sep 12, 2023

Conversation

sitaram-kalluri
Copy link
Member

- What I did

- How I did it

  • Create an abstract class called AtRateLimiter that includes a method called isRequestAllowed. This method should return a boolean value based on the rate limit rules.
  • Modify the InboundConnection class to implement the AtRateLimiter abstract class.
  • The mentioned PR contains the implementation.

gkc
gkc approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gkc
gkc approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkc gkc merged commit 4ba3921 into trunk Sep 12, 2023
17 checks passed
@gkc gkc deleted the rate_limit_spec branch September 12, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@murali-shris murali-shris Awaiting requested review from murali-shris

@VJag VJag Awaiting requested review from VJag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitaram-kalluri @gkc