Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add melos bootstrap action #1576

Merged
merged 9 commits into from
Oct 2, 2023
Merged

ci: add melos bootstrap action #1576

merged 9 commits into from
Oct 2, 2023

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Sep 21, 2023

- What I did

  • Used more specific glob patterns for the melos package definitions to avoid selecting unwanted packages

- How I did it

- How to verify it

- Description for the changelog
ci: add melos bootstrap action

@XavierChanth XavierChanth requested a review from cpswan September 21, 2023 08:09
@XavierChanth
Copy link
Member Author

This failure is a sign that our packages in this repo don't share any common dependency constraints. In this case, specifically for at_commons

@XavierChanth
Copy link
Member Author

The issue is a result of pinning in at_root_server. I'm not sure as to why we've chosen to do that, but our options are as follows:

  • Update the version constraints to ones that are compatible with the rest of our packages.
  • Ignore it from the melos tool.

@cpswan what do you think is the best course of action here?

@cpswan
Copy link
Member

cpswan commented Sep 21, 2023

@XavierChanth at_root_server and at_secondary_server both have pinned dependencies as they're services rather than packages. Maybe they shouldn't even be in the packages directory?

at_root_server might have slipped behind on deps, as I don't think it's covered by Dependabot.

@XavierChanth
Copy link
Member Author

@XavierChanth at_root_server and at_secondary_server both have pinned dependencies as they're services rather than packages. Maybe they shouldn't even be in the packages directory?

at_root_server might have slipped behind on deps, as I don't think it's covered by Dependabot.

I think the best course of action is to check with and without, so I setup a matrix that will bootstrap with everything, and also everything but at_root_server and at_secondary.

I also put in the dependabot config for at_root_server

.github/workflows/melos_bootstrap.yaml Outdated Show resolved Hide resolved
@XavierChanth
Copy link
Member Author

melos really doesn't like the git ref when bootstrapping... but I can't seem to produce the same issue on my local

@XavierChanth
Copy link
Member Author

XavierChanth commented Sep 29, 2023

@cpswan I changed it so that the default was to filter out and ignore the packages with pinned dependencies by default (since they aren't a worry for this check anyways - because they aren't being published)

@XavierChanth XavierChanth requested a review from cpswan September 29, 2023 14:28
@XavierChanth XavierChanth merged commit a59d664 into trunk Oct 2, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants