-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Update ruamel-yaml requirement from 0.17.40 to 0.18.0 in /tools #1640
Conversation
Updates the requirements on [ruamel-yaml](https://sourceforge.net/p/ruamel-yaml/code/ci/default/tree) to permit the latest version. --- updated-dependencies: - dependency-name: ruamel-yaml dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
@sitaram-kalluri ruamel-yaml 0.18.0 has introduced changes that break how we have been using it. Let's use this PR to get things fixed. Do you have some tests we can use to verify that the new approach does what we need it to? |
I can see that the tests aren't failing as they were before, but it's for the trivial use case of dependency overrides being empty. So I'd like to ensure that the changes work with an actual dependency override before getting this merged. |
@cpswan : We do not have tests to assert the "add_dependency_overrides.py" script. The initial intent of adding the script was to add the "dependency_overrides" section to the pubspec.yaml during running of tests in the GITHub actions. However, I believe we are not using it anymore. |
@sitaram-kalluri for sure. I'm always happy to remove unnecessary code |
@cpswan : Removed the usage of "add_dependency_overrides.py" script. Please review the PR. |
Thanks @sitaram-kalluri, I did a little more tidy up, and now I think it's ready to go. |
Updates the requirements on ruamel-yaml to permit the latest version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)