fix: Add scan regex for failing functional tests #1647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add a work around to fix the failing functional tests in the following link https://github.com/atsign-foundation/at_server/actions/runs/6650002663/job/18069387859
The server response is sent in two packets where as below
In test, socket messageHandler method has following condition to add response to the queue:
if (data.last == 64 && data.contains(10))
which looks for the "@" and "\n". So the response received in the first packet (which starts with "data:" is not added to queue)In the second packet, though there is a key, since it does not start with "data:", the read assumes that it is not a valid a response and ignores it.
As a work around, add regex to the scan verb to reduce the number of keys in the scan response.