Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: <breaking_change> persistence spec refactoring to replace metadata params with metadata object from at_commons #1813

Draft
wants to merge 9 commits into
base: trunk
Choose a base branch
from
Draft

feat: <breaking_change> persistence spec refactoring to replace metadata params with metadata object from at_commons #1813

wants to merge 9 commits into from

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Feb 21, 2024 •
edited
Loading

- What I did

  • refactored persistence spec to replace optional metadata params with metadata from at_commons
  • any future addition of metadata will not affect the method signature in the spec
    - How I did it
  • added dependency to at_commons
  • changed method signature of put/create methods in Keystore to replace optional metadata params with metadata object from at_commons
  • removed putAll method since put method should suffice for updating either value or metadata or both
    - How to verify it
  • verify the tests in persistence secondary and server after uptaking the spec changes
  • tests in this PR
    feat: Persistence impl refactoring #1822

@murali-shris murali-shris changed the title feat: persistence spec refactoring to replace metadata params with metadata object from at_commons feat: <breaking_change> persistence spec refactoring to replace metadata params with metadata object from at_commons Feb 21, 2024
gkc
gkc approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murali-shris murali-shris mentioned this pull request Mar 4, 2024
Open
@gkc
Copy link
Contributor

gkc commented Mar 28, 2024

@murali-shris What's the status of this PR? Should it be merged, or closed?

@murali-shris
Copy link
Member Author

Will revisit this PR after hive_ce changes are done. Marking as draft for now

@murali-shris murali-shris marked this pull request as draft November 29, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murali-shris @gkc @srieteja