Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add enroll param values to notification value and update the functional test to verify new fields in the notification value #1819

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

sitaram-kalluri
Copy link
Member

@sitaram-kalluri sitaram-kalluri commented Feb 26, 2024

- What I did

  • Currently, the enrollment request that is sent to the approving app does not contain the information about the enrollment, such as the which app has requested for access and what namespaces is the app requesting for? So, to enable the approving app to get this information, send "appName", "deviceName" and "namespace" to the approving app.
  • Update the functional tests with use "encryptedDefaultEncryptedPrivateKey" to "encryptedDefaultEncryptionPrivateKey".

- How I did it

  • When notifying the enrollment request from the server to the approving app via the monitor connection, add the necessary information to the notification value.
  • Currently only encryptedAPKAMSymmetric key is being notified. Add "appName", "deviceName" and "namespaces" to the notification value.

- How to verify it

  • Extended the functional tests to verify the notification value in the monitor connection contains appName, deviceName and namespaces.

- Description for the changelog

  • Add enroll param values to notification value

…ctional test to verify new fields in the notification value
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@murali-shris murali-shris merged commit 2d859cd into trunk Feb 26, 2024
21 checks passed
@murali-shris murali-shris deleted the add_fields_to_enroll_notifications branch February 26, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants