Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apkam - add IV to self encryption key and encryption private key #2170

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Dec 5, 2024

- What I did

  • changes to store IV along with self encryption and encryption private key data in keystore for apkam.
    - How I did it
  • in enroll verb handler, add IV to keystore data if IV is sent in enroll:approve params
  • added check in functional test to verify whether IV is sent in keys:get response
  • in enroll verb handler, removed storing of encryption private key and self encryption key for first enrollment. Removed corresponding check in functional test

- How to verify it

  • tests should pass

@murali-shris murali-shris changed the title fix: apkam add IV to self encryption key and encryption private key d… fix: apkam - add IV to self encryption key and encryption private key Dec 5, 2024
@murali-shris murali-shris marked this pull request as ready for review December 5, 2024 13:59
gkc
gkc previously requested changes Dec 5, 2024
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need two IVs

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I misread the code. Looks good but I'd like to talk through both this PR and the other ones tomorrow before we merge

@gkc gkc dismissed their stale review December 5, 2024 14:18

misread the PR

@gkc gkc self-requested a review December 5, 2024 14:19
gkc

This comment was marked as off-topic.

@gkc gkc merged commit 0cf04d7 into trunk Dec 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants