Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhanced options screen UI fixes issue #153 #191

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

SamridhiSethi13
Copy link
Contributor

@SamridhiSethi13 SamridhiSethi13 commented Mar 23, 2022

- What I did
I have enhanced the UI of the options screen by equalizing the unequal sizes of fields present in it.

- How I did it
I varied the sizes of containers, adjusted the heights of sizedboxes, and suitably aligned them in the options screen.

- How to verify it
For verification please refer to the following before and after screenshots:-

BEFORE Before AFTER After

- Description for the changelog
I made changes in the heights of sizedboxes which were unequal and also made some changes in size of containers in order to make the size equal of all fields.

@SamridhiSethi13
Copy link
Contributor Author

SamridhiSethi13 commented Mar 24, 2022

@yahu1031 @nitesh2599 @sarika01 @tinashe404 Could anyone of you please review this?

@SamridhiSethi13 SamridhiSethi13 changed the title enhanced options screen UI enhanced options screen UI fixes issue #153 Mar 25, 2022
@yahu1031 yahu1031 requested a review from nitesh2599 March 28, 2022 19:13
@nitesh2599
Copy link
Contributor

@SamridhiSethi13 While the changes look fine, but am not sure why is package_info_plus_web package added. If it is not needed then please remove this.

@SamridhiSethi13
Copy link
Contributor Author

@nitesh2599 removed package_info_plus_web. Please check now.

@nitesh2599 nitesh2599 merged commit 87e7836 into atsign-foundation:trunk Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants