Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove file_selector and only use file_picker #887

Closed
wants to merge 3 commits into from
Closed

fix: remove file_selector and only use file_picker #887

wants to merge 3 commits into from

Conversation

XavierChanth
Copy link
Member

- What I did

Some history here:

  • We started using file_picker in its early days, before it supported desktop well
    • We preferred it for mobile but needed file_selector for mobile
    • The native api calls are hanging on macos with file_selector, thus I've also switched to file_picker for desktop too.

- How I did it

- How to verify it

- Description for the changelog
fix: remove file_selector and only use file_picker

@XavierChanth XavierChanth mentioned this pull request Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XavierChanth