Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #218 UI Redesign - Mobile - My Files #239

Open
wants to merge 34 commits into
base: ui_redesign
Choose a base branch
from

Conversation

Ayush783
Copy link

- What I did
Redesigned My Files screen as per the designs in figma and as stated inn issue #218.
- How I did it
Modified the following files :-
- /screens/my_files/my_files.dart
- /screens/common_widgets/app_bar.dart
Created the following widgets under my_files folder
- FileFormatDropDownButton
- FileListView
- FileListTile
- MyFilesToolbox
- SearchButton
- RefreshButton
Added required images, icons, fonts as per the Figma design.
- How to verify it

- Description for the changelog
Redesigned My Files screen.

Sardar1208 and others added 30 commits September 11, 2022 07:55
…haring_intent

fix: sharing intent problem on android
…dd_unknown_contact

chore: made width constant for adding contacts
…cons-others

chore: changed the icons of other file types
@Ayush783 Ayush783 changed the title Completes #218 UI Redesign - Mobile - My Files Fix #218 UI Redesign - Mobile - My Files Oct 11, 2022
@Ayush783 Ayush783 changed the title Fix #218 UI Redesign - Mobile - My Files Fix: #218 UI Redesign - Mobile - My Files Oct 11, 2022
@Ayush783 Ayush783 changed the title Fix: #218 UI Redesign - Mobile - My Files fix: #218 UI Redesign - Mobile - My Files Oct 11, 2022
@tinashe404
Copy link
Member

I'm not able to build this.. @nitesh2599 are you able to get this to build successfully?

@Ayush783
Copy link
Author

I'm a little confused. There were no conflicts when I made this PR but its showing them now :/

@Ayush783
Copy link
Author

Let me resolve this

@Ayush783
Copy link
Author

I ran into a build error that said something about declaration of AtBackupKeyFlutterPlugin. If you're facing the same error then try running pub cache repair and then flutter clean. This helped me.

@tinashe404
Copy link
Member

@Ayush783 this is a great start on this. I see that you haven't linked any of the existing My Files functionality to the UI, ie it isn't displaying the actual files that would have been received (its displaying hardcoded items), refresh, search and filter don't do anything as yet. Is this something you plan on doing?

A few minor UI things

  • the text above the buttons is not the same size. It looks like Delivery Type is much bigger.
  • the color of this text is too pale
  • the orange gradient at the bottom of the screen isn't present

@Ayush783
Copy link
Author

@tinashe404 Thanks for the review, I was hoping to get the UI reviewed first. I'll get these issues fixed and then try to work on the functionalities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants