Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure NptImpl's preRun is being executed only once when npt cli is run without the -x flag #1290

Merged
merged 5 commits into from
Aug 23, 2024
Merged

fix: ensure NptImpl's preRun is being executed only once when npt cli is run without the -x flag #1290

merged 5 commits into from
Aug 23, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Aug 23, 2024

- What I did
Fixes #1287

- How I did it
See commits

- How to verify it

  • Existing automated tests pass
  • I have manually tested the fix; there will be a follow-up PR to add an e2e test covering this scenario

@gkc gkc requested a review from cconstab August 23, 2024 18:42
cconstab
cconstab approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@cconstab cconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working fine with 'npt' to a remote machine and connecting to a remote daemon (sshd in my test case)

@gkc gkc merged commit 689112f into trunk Aug 23, 2024
7 checks passed
@gkc gkc deleted the gkc/fix-1287 branch August 23, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconstab cconstab cconstab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5.6.0 npt x64 binary hanging
2 participants
@gkc @cconstab