Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the
Display
struct to own aSwapchain
, instead of operating in conjunction with it. Fixes the incorrect "image ready" fence which was waited upon before submitting new frames.The previous behavior was unsound and only worked on certain hardware.
The new pattern greatly simplifies swapchain handling:
Display
Process:
vkAcquireNextImageKHR
signals an "acquire" semaphore when the image is availablevkQueuePresentKHR
waits for "rendered" before presenting the imageAdditionally, recreating the swapchain no longer uses
vkDeviceWaitIdle
. This improves window resizing performance.