Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DB for usage examples. #33

Closed
wants to merge 8 commits into from
Closed

Use DB for usage examples. #33

wants to merge 8 commits into from

Conversation

attila0x2A
Copy link
Owner

This is #32 + additionally moving to using database for usage examples.

RomanTymchyshyn and others added 8 commits August 8, 2020 12:57
The new top-level structure has several advantages compared to the
action-based structure it replaces:
1. It's easier to see what commands are supported just from glancing
over at the commands template.
2. There is less duplication in the commands definition, so it should be
much easier to add additional commands, and settings.
3. Overall behaviour becomes less statefull. It's annoying to do /stop
in the middle of the practive to look up some word from the usage
examples.
Using DB instead of loading content of csv files into the memory would
reduce server's memory usage greatly.
Image size is reduced more than 10x which makes it easier to deploy new
images faster.
On the server with 2GB RAM Memory usage dropped from 73% to 13% after
the new image was deployed.
Makes building images slightly faster.
This is mostly for convenience.
@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@attila0x2A
Copy link
Owner Author

This also addresses part of #6

@attila0x2A attila0x2A linked an issue Oct 26, 2020 that may be closed by this pull request
@RomanTymchyshyn
Copy link
Collaborator

@googlebot I consent.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@attila0x2A attila0x2A closed this Nov 2, 2020
@attila0x2A
Copy link
Owner Author

Superseded by #34

@attila0x2A attila0x2A deleted the usage_db branch November 2, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store more stuff in DB
3 participants