Webhook approach to reduce latency + deployment script #34
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
The new top-level structure has several advantages compared to the action-based structure it replaces: 1. It's easier to see what commands are supported just from glancing over at the commands template. 2. There is less duplication in the commands definition, so it should be much easier to add additional commands, and settings. 3. Overall behaviour becomes less statefull. It's annoying to do /stop in the middle of the practive to look up some word from the usage examples.
Using DB instead of loading content of csv files into the memory would reduce server's memory usage greatly.
Image size is reduced more than 10x which makes it easier to deploy new images faster. On the server with 2GB RAM Memory usage dropped from 73% to 13% after the new image was deployed.
Makes building images slightly faster.
This is mostly for convenience.
With Webhook setup telegram will push updates to the bot. This will reduce latency for users and avoid polling behaviour.
There are several commands that we need to run to deploy the application. The script makes building and deploying a single command.
The deployment script is a step towards #7. It might be enough for now.
This PR builds up on #33.