Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Avoid calling unwrap() when we don't have to #2519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

style: Avoid calling unwrap() when we don't have to #2519

wants to merge 1 commit into from

Conversation

andrewaylett
Copy link

Use if let rather than is_some() followed by unwrap(), and coerce errors instead of calling unwrap() when available.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@andrewaylett
style: Avoid calling unwrap() when we don't have to
949b0f5 
Use `if let` rather than `is_some()` followed by `unwrap()`, and coerce
errors instead of calling `unwrap()` when available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewaylett