Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: do not truncate string features #110

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Fix: do not truncate string features #110

merged 3 commits into from
Mar 29, 2023

Conversation

frankenjoe
Copy link
Collaborator

Closes #109

@frankenjoe frankenjoe requested a review from hagenw March 28, 2023 12:35
@frankenjoe
Copy link
Collaborator Author

I was already afraid of running into problems when pre-allocating the numpy array. I should also add some tests to cover it in the future.

@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Merging #110 (4a338e5) into main (a242a55) will not change coverage.
The diff coverage is 100.0%.

Impacted Files Coverage Δ
audinterface/core/feature.py 100.0% <100.0%> (ø)

@frankenjoe
Copy link
Collaborator Author

I was already afraid of running into problems when pre-allocating the numpy array. I should also add some tests to cover it in the future.

@frankenjoe
Copy link
Collaborator Author

I should also add some tests to cover it in the future.

done

@frankenjoe frankenjoe mentioned this pull request Mar 28, 2023
Closed
@hagenw
Copy link
Member

hagenw commented Mar 29, 2023

The new test fails indeed for the main branch.

I also tested performance of your new changes. The execution time for this branch and the main branch is the same when executing the benchmark proposed in #103

@hagenw
Copy link
Member

hagenw commented Mar 29, 2023

The title of this pull request is slightly too long, maybe rename to:
"Fix: do not truncate string features"

@frankenjoe frankenjoe changed the title Fix: do not truncate features when return value is a string Fix: do not truncate string features Mar 29, 2023
@frankenjoe
Copy link
Collaborator Author

The title of this pull request is slightly too long, maybe rename to:
"Fix: do not truncate string features"

done

@hagenw hagenw merged commit 755b4d6 into main Mar 29, 2023
@hagenw hagenw deleted the fix-feature-string branch March 29, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagenw hagenw Awaiting requested review from hagenw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String output in processing function is truncated in audinterface version 1.0.0
2 participants
@frankenjoe @hagenw