Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: install portaudio #182

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CI: install portaudio #182

wants to merge 3 commits into from

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Nov 21, 2024

To fix the tests under Mac and Ubuntu, we need to install portaudio, compare https://github.com/audeering/audinterface/actions/runs/11955509905/job/33328050030?pr=181.

Summary by Sourcery

CI:

  • Add installation step for portaudio on MacOS in CI workflow to ensure compatibility with latest runner versions.

Copy link

sourcery-ai bot commented Nov 21, 2024

Reviewer's Guide by Sourcery

This PR adds a new step in the CI workflow to install the portaudio dependency specifically for macOS runners. The change is implemented by adding a conditional step in the GitHub Actions workflow that runs only on macOS environments.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added macOS-specific dependency installation in CI workflow
  • Added new 'Prepare Macos' step that installs portaudio using brew
  • Added conditional execution for macOS using 'if matrix.os' condition
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • The if condition has incorrect syntax and is missing required expression syntax (link)

Overall Comments:

  • The if condition needs to be corrected to if: ${{ matrix.os == 'macos-latest' }} to follow GitHub Actions syntax
Here's what I looked at during the review
  • 🔴 General issues: 1 blocking issue
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (a9bc048) to head (369fab5).

Additional details and impacted files
---- 🚨 Try these New Features:

@hagenw hagenw changed the title CI: install portaudio for Macos CI: install portaudio Nov 21, 2024
@hagenw hagenw requested a review from ChristianGeng November 21, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant