-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: install portaudio #182
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR adds a new step in the CI workflow to install the portaudio dependency specifically for macOS runners. The change is implemented by adding a conditional step in the GitHub Actions workflow that runs only on macOS environments. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- The if condition has incorrect syntax and is missing required expression syntax (link)
Overall Comments:
- The if condition needs to be corrected to
if: ${{ matrix.os == 'macos-latest' }}
to follow GitHub Actions syntax
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
To fix the tests under Mac and Ubuntu, we need to install
portaudio
, compare https://github.com/audeering/audinterface/actions/runs/11955509905/job/33328050030?pr=181.Summary by Sourcery
CI: