Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on audmath>=1.3.0 #148

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Depend on audmath>=1.3.0 #148

merged 1 commit into from
Jan 29, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jan 29, 2024

audiofile uses audmath.samples() under the hood, which was only introduced in audmath v1.3.0, so we need to require at least that version of audmath.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15355bd) 100.0% compared to head (baea032) 100.0%.
Report is 1 commits behind head on main.

Additional details and impacted files

see 2 files with indirect coverage changes

@hagenw hagenw requested a review from schruefer January 29, 2024 15:48
Copy link
Member

@schruefer schruefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@hagenw hagenw merged commit 31de997 into main Jan 29, 2024
34 checks passed
@hagenw hagenw deleted the audmath-1.3.0 branch January 29, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants