Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wrapper is blocking the anchor tag to be clicked #5

Open
codercampos opened this issue Feb 10, 2020 · 7 comments
Open

The wrapper is blocking the anchor tag to be clicked #5

codercampos opened this issue Feb 10, 2020 · 7 comments

Comments

@codercampos
Copy link

Description

After you publish/preview the post, the embed is generated successfully but the user can't click the link the embed plugin.

Expected Behavior

The user should see the Repo information in the embed and able to click on it. A new tab should be created with the target selected.

Current Behavior

The embed does not open the link.

Browsers Tested

Edge (Chromium edition) - Version 80.0.361.48 - macOS Catalina
Chrome - Version Version 80.0.3987.87 - macOS Catalina
Safari - Version 13.0.4 (15608.4.9.1.3) - macOS Catalina

I already forked the project and start working in a workaround for this (I did a temporary solution but it seems it does not follow the standards. It may broke in other OS's).

@grayknight2
Copy link

Links not working for me

@grayknight2
Copy link

I solved it with CSS, but not sure if this is a clean way.

.ebg-br-wrapper > .ebg-br-background-image {
    background-image: url('images/github.svg');
    background-repeat: no-repeat;
    background-position: calc(100% - 0.5em) 0.5em;
    background-size: 20px 20px;
    left: 0;
    top: 0;
    width: 0%;
    height: 100%;
    position: relative;
}

@codercampos
Copy link
Author

@grayknight2 Check PR #7 or #6 for current workarounds (you have to do this manually meanwhile the PR #7 is being merged)

@oakie
Copy link

oakie commented May 13, 2020

I solved this with a single line of custom css:
.ebg-br-wrapper > .ebg-br-background-image { pointer-events: none; }

@alexynior28
Copy link

I solved this with a single line of custom css:
.ebg-br-wrapper > .ebg-br-background-image { pointer-events: none; }

Thanks, that works.

@phillipjohnston
Copy link

Links are also not working for me, but the CSS workaround does the trick.

@shredEngineer
Copy link

Yep, links are not working. I mean... WHAT? Come on!
The plugin looks fine (best looking available), but this is ridiculous.
Also, dark mode isn't working for me, but that's for another time.

CharlieEtienne added a commit to CharlieEtienne/embed-block-for-github that referenced this issue Nov 11, 2020
mjbohn added a commit to mjbohn/embed-block-for-github that referenced this issue Mar 22, 2023
Added z-index to .ebg-br-wrapper .ebg-br-main{} to fix issues audrasjb#5 and audrasjb#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants