Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Users, reorganize, implement fontawesome to remove SVG images #7

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

API Users, reorganize, implement fontawesome to remove SVG images #7

wants to merge 17 commits into from

Conversation

vsc55
Copy link
Contributor

@vsc55 vsc55 commented Feb 18, 2020

Add support to github url with the user's profile and it will show the information.
Rearrange files.
Delete SVG files, now the images are class fontawesome.

vsc55 and others added 9 commits February 9, 2020 11:16
@vsc55
Merge pull request #1 from audrasjb/master
4c84879 
Update
@vsc55
correct spelling error.
46a124e 
add text that did not implement i18n/l10n.
@vsc55
Add image in links.
9c24f49 
Sort style sheets and delete code not necessary.
@vsc55
Add box when an error message is generated.
adfa345 
Detect if the url is not from a repository and corresponds to a user, in this case it shows the user's information.
Create an external object to manage transitions.
@vsc55
Update info-user template.
cb41bab 
Rename template repository to info-repo.
Control darkmode in info-user edition mode.
Have the collection of data from the github api that will be used for the replacements in the templates be dynamically added.
@vsc55
organize code
9953cae 
name change "dark-mode" by "dark-theme"fork
change image on_off
@vsc55
Delete SVG files, now the images are class fontawesome.
22b4780 
Finish adjusting users template.
Update all templates.
@vsc55
fix
1f20215
@vsc55
Hide "Starter" in the user information, it does not work yet.
539ca02
@vsc55
Copy link
Contributor Author

vsc55 commented Feb 18, 2020

Fix issues #5

@vsc55 vsc55 mentioned this pull request Feb 18, 2020
Closed
@audrasjb
Copy link
Owner

Hi,
Thank you for this pull request @vsc55 !
The support for user's profile looks great, but I'd prefer to keep SVG images instead of using icons from an external library (font awesome). Could you please propose the first feature separately?

Thanks!
Jb

@vsc55
Copy link
Contributor Author

vsc55 commented Feb 18, 2020

Hi,
OK no problem.
And how about having both options?
Just add a check to select if you want to use SVG images or fontawesome icons.

Best regards.

vsc55 and others added 4 commits February 18, 2020 22:12
@vsc55
API Users
a471270 
Update Master API Users
@vsc55
files svg recovery
406d357 
Add option for select the source icon file svg or Font Awesome.
Pending implement select source icon.
@vsc55
Add images for user template.
2851b79 
Add option in config block for select images source.
@vsc55
Add suport files SVG and Font Awesome
c8048dd 
Add images for user template.
Add option in config block for select images source.
@vsc55
Copy link
Contributor Author

vsc55 commented Feb 19, 2020

It's ready.
Although the images of Followers, Following, Public Repo and Pubic Gist do not know if they like them very much.

@codercampos
Copy link

codercampos commented Mar 18, 2020 •
edited
Loading

If this solves issue #5 I can close PR #6 after merged.

@codercampos codercampos mentioned this pull request Mar 18, 2020
Open
@codercampos codercampos mentioned this pull request Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsc55 @audrasjb @codercampos