add phpstan, fix docblocks, also run phpstan in ci (#216)

.github/workflows/ci.yml

@@ -52,4 +52,4 @@ jobs:
         run: composer install --classmap-authoritative
 
       - name: Run tests
-        run: ./vendor/bin/phpunit
+        run: composer test

composer.json

@@ -29,7 +29,8 @@
     "require-dev": {
         "producer/producer": "^2.3",
         "yoast/phpunit-polyfills": "^2.0",
-        "phpunit/phpunit": "^9.0 || ^10.0"
+        "phpunit/phpunit": "^9.0 || ^10.0",
+        "phpstan/phpstan": "^1.11.1"
     },
     "autoload-dev": {
         "psr-4": {
@@ -38,5 +39,11 @@
     },
     "provide": {
         "psr/container-implementation": "^1.0"
+    },
+    "scripts": {
+        "test": [
+            "./vendor/bin/phpunit",
+            "./vendor/bin/phpstan analyse -l 5 src"
+        ]
     }
 }

src/Injection/Factory.php

@@ -73,7 +73,6 @@ public function withContext(Blueprint $contextualBlueprint): self
      * factory can make its own, using sequential params in a function; then
      * the factory call can be replaced by a call to this Factory.
      *
-     * @param array $params
      * @return object
      */
     public function __invoke(Resolver $resolver): object

src/Injection/LazyGet.php

@@ -44,10 +44,10 @@ class LazyGet implements LazyInterface
      *
      * Constructor.
      *
-     * @param ContainerInterface $container The service container.
-     *
      * @param string $service The service to retrieve.
      *
+     * @param ?ContainerInterface $delegatedContainer The service container.
+     *
      */
     public function __construct(string $service, ?ContainerInterface $delegatedContainer = null)
     {

src/Injection/LazyValue.php

@@ -33,8 +33,6 @@ class LazyValue implements LazyInterface
      *
      * Constructor.
      *
-     * @param Resolver $resolver The Resolver that holds the values.
-     *
      * @param string $key The value key to retrieve.
      *
      */
@@ -47,6 +45,8 @@ public function __construct(string $key)
      *
      * Returns the lazy value.
      *
+     * @param Resolver $resolver The Resolver that holds the values.
+     *
      * @return mixed
      *
      */

src/Resolver/AutoResolver.php

@@ -12,6 +12,7 @@
 use Aura\Di\Injection\LazyNew;
 use ReflectionClass;
 use ReflectionException;
+use ReflectionNamedType;
 use ReflectionParameter;
 
 /**
@@ -59,7 +60,7 @@ protected function getUnifiedParam(ReflectionParameter $rparam, string $class, a
         }
 
         try {
-            $rtype = $rparam->getType()
+            $rtype = $rparam->getType() instanceof ReflectionNamedType
                 ? new ReflectionClass($rparam->getType()->getName())
                 : null ;
         } catch (ReflectionException $re) {

src/Resolver/Resolver.php

@@ -141,7 +141,7 @@ public function &__get($key): array
      * @param object $val The service object; or callable.
      *
      */
-    public function setService(string $service, object $val): void
+    public function setService(string $service, object|callable $val): void
     {
         $this->services[$service] = $val;
     }