do not use reflection to instantiate objects, use new instead

auraphp · May 16, 2024 · dc90cfc · dc90cfc
1 parent 149711e
commit dc90cfc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/Resolver/Blueprint.php b/src/Resolver/Blueprint.php
@@ -76,14 +76,14 @@ public function merge(Blueprint $mergeBlueprint): Blueprint
     /**
      * Instantiates a new object based on the current blueprint.
      *
-     * @param ReflectionClass $reflectedClass
-     *
      * @return object
      */
-    public function __invoke(Resolver $resolver, ReflectionClass $reflectedClass): object
+    public function __invoke(Resolver $resolver): object
     {
-        $object = $reflectedClass->newInstanceArgs(
-            array_map(
+        $className = $this->className;
+
+        $object = new $className(
+            ...array_map(
                 function ($val) use ($resolver) {
                     // is the param missing?
                     if ($val instanceof UnresolvedParam) {

diff --git a/src/Resolver/Resolver.php b/src/Resolver/Resolver.php
@@ -221,7 +221,6 @@ public function resolve(Blueprint $blueprint, array $contextualBlueprints = []):
             return call_user_func(
                 $this->expandParams($this->getUnified($blueprint->getClassName())->merge($blueprint)),
                 $this,
-                $this->reflector->getClass($blueprint->getClassName())
             );
         }
 
@@ -255,7 +254,6 @@ public function resolve(Blueprint $blueprint, array $contextualBlueprints = []):
         $resolved = call_user_func(
             $this->expandParams($this->getUnified($blueprint->getClassName())->merge($blueprint)),
             $this,
-            $this->reflector->getClass($blueprint->getClassName())
         );
 
         foreach ($contextualBlueprints as $contextualBlueprint) {