Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and improvements to support multiple bridges #84

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

sept-en
Copy link
Contributor

@sept-en sept-en commented Jan 11, 2022

As we start to have multiple bridges in the repo already, it makes sense to have some sanity on it so both users and tools won't have controversial and misleading data for tokens.

Summary:

  • Tokens list gen tool: add allbridge tag and rules;
  • Define new rules for creating PRs;
  • Update Allbridge-related files according to new rules.
  • Update tokens list.

@sept-en sept-en added the enhancement New feature or request label Jan 11, 2022
Copy link
Member

@paouvrard paouvrard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we need to include the network in tags, maybe using a single tag consisting of the bridge name is enough to differentiate tokens. For example UST is not native to Ethereum even if it was bridged from there via RainbowBridge so we could make a rainbowbridge tag.

@mfornet
Copy link
Contributor

mfornet commented Jan 13, 2022

I was wondering if we need to include the network in tags, maybe using a single tag consisting of the bridge name is enough to differentiate tokens. For example UST is not native to Ethereum even if it was bridged from there via RainbowBridge so we could make a rainbowbridge tag.

Agree with this proposal, and created an issue for it (#87). @sept-en @karim-en lmk your opinion in this regard.

@sept-en
Copy link
Contributor Author

sept-en commented Jan 13, 2022

@paouvrard @mfornet thanks for your suggestions! Let's continue the discussion in that mentioned issue.

@sept-en sept-en merged commit 0b421b1 into master Jan 13, 2022
@sept-en sept-en deleted the multiple-bridges-refactoring branch January 13, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants