Add STANDARD_GRAVITY Constant
#348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes more sense, and the only reason we didn't do it in the first place is that we hadn't yet invented `Constant` in the library.
chiphogg
added
release notes: 🗑️ lib (deprecation)
|
I should think this through some more. |
It might be too confusing for a unit that doesn't follow the pattern of other units.
chiphogg
changed the title
StandardGravity unit, for a constantSTANDARD_GRAVITY Constant
chiphogg
removed
the
release notes: 🗑️ lib (deprecation)
geoffviola
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a little while to figure out exactly what I wanted to do
here.
Initially, I was going to deprecate the standard gravity unit. Then I
realized we need it to define certain other units, such as the
correspondence between "pounds" as a force and a mass --- and I didn't
want to introduce a circular dependency between
:unitsand:constants.Then I was going to deprecate only the quantity maker,
standard_gravity. But then I realized it would be weird to create asituation where certain units have quantity makers, and certain other
ones don't.
In the end, I think the right move is to just provide standard gravity
as a new constant. This is the preferred way to interact with it, but
the old ways will still be there for the foreseeable future.
Follow-on to #90.