Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Buffer undefined reference error #704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Buffer undefined reference error #704

wants to merge 1 commit into from

Conversation

yongjun21
Copy link

@yongjun21 yongjun21 commented Jul 6, 2022 •
edited
Loading

instanceof Buffer throws error on browser as instanceof undefined is a reference error.

This problem does not show up previously as Webpack injects a polyfill for Buffer. However other build tools like Vite or Rollup does not polyfill Buffer so throwing an uncaught error.

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yongjun21 @CLAassistant