Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #1

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Update #1

merged 1 commit into from
Dec 5, 2024

Conversation

austinsonger
Copy link
Owner

No description provided.

@austinsonger austinsonger merged commit 73d2ed1 into main Dec 5, 2024
1 of 3 checks passed
Copy link

@reviewabot reviewabot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Comments:

  1. Unnecessary Whitespace Change:

    • In the mdbook-build-deploy.yml file, the removal of the trailing whitespace in the install mdBook step is unnecessary. While it doesn't affect functionality, it is generally good practice to avoid such changes unless they serve a purpose.
  2. Inconsistent Indentation:

    • Ensure that the indentation in the mdbook-build-deploy.yml file is consistent. The indentation level should be uniform across the file for better readability.
  3. File Path Change:

    • In the book.toml file, the src path has been changed from docs to content. Ensure that this change is intentional and that all references to the src path are updated accordingly in the project.
  4. Theme Path Change:

    • The theme path has been updated to /content/theme/default. Verify that this path is correct and that the theme files are located in the specified directory.
  5. Newline at End of File:

    • Ensure that all files end with a newline. The book.toml file should end with a newline to adhere to POSIX standards.

Summary:

  • The changes are mostly straightforward, but ensure that the path updates are intentional and correct.
  • Maintain consistent indentation and avoid unnecessary whitespace changes.
  • Ensure all files end with a newline.

Please address these comments before merging the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant