Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML Support #120

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SAML Support #120

wants to merge 5 commits into from

Conversation

luckpoint
Copy link
Contributor

✏️ Changes

Added SAML support.

  • Added protocol to identify which protocol used (samlp or oauth2) in Rules.
  • If SAML is used, then call authorizeSaml, not authorize.

🔗 References

  • [PDOPPS-322]

🎯 Testing

There are two tenants required for testing. SAML IdP and SAML SP.

  1. Tester creates a user in Username-Password-Authentication at SAML IdP (Auth0)
  2. Tester initiates SAML Login from SAML SP side.
  3. Browser redirected SAML IdP and showed login screen at SAML IdP
  4. Tester login with Social provider (ex; google-oauth2).
  5. Account link is launched, and the tester proceeds account link
  6. Tester login with the credentials created at (1)
  7. Account link completes

public/index.js Outdated
let clientId = qs["client_id"];
let connection = encodeURIComponent(qs["connection"]);
let link_account_token = encodeURIComponent(qs["link_account_token"]);
window.location = domain + `samlp/${clientId}?connection=${connection}&link_account_token=${link_account_token}&prevent_sign_up=true`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we send the original RelayState here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed.
image

@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants