BREAKING CHANGE: updated description of AuthenticationException in case of empty description #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se of empty description
pmathew92
approved these changes
Sep 3, 2024
Trixie2993
approved these changes
Sep 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: updated description of AuthenticationException in case of empty description
Previously the
getException()ofAuthenticationExceptionobject is returning a string with valueReceived error with code a0.sdk.internal_error.unknowninstead ofFailed with unknown errordue to an in-correct branching logic when the code of the exception isa0.sdk.internal_error.unknown.We are fixing it as part of this to return the description as
Failed with unknown error.References
#755
Testing
All the existing unit tests are passing after updating them accordingly as per the code changes in this PR
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors