Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash when getTokenSilently returns null #458

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Do not crash when getTokenSilently returns null #458

merged 1 commit into from
Jul 24, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Jul 24, 2023 •
edited
Loading

Description

When nothing was found in the cache, the getAccessTokenSilently would crash.

References

Closes #457

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck requested a review from a team as a code owner July 24, 2023 06:41
@frederikprijck frederikprijck mentioned this pull request Jul 24, 2023
Closed
6 tasks
@frederikprijck frederikprijck merged commit 24fd0c1 into master Jul 24, 2023
5 checks passed
@frederikprijck frederikprijck deleted the fix/457 branch July 24, 2023 07:41
@frederikprijck frederikprijck mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError when calling getAccessTokenSilently cache-only while no user is logged in
2 participants
@frederikprijck @Widcket