Skip to content

Commit

Permalink
Revert "Make OAuthError extend GenericError" (#646)
Browse files Browse the repository at this point in the history
  • Loading branch information
frederikprijck authored Nov 2, 2023
1 parent 5167b2e commit 2ac5c94
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
7 changes: 0 additions & 7 deletions __mocks__/@auth0/auth0-spa-js.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,3 @@ export const Auth0Client = jest.fn(() => {
logout,
};
});

export class GenericError extends Error {
constructor(public error: string, public error_description: string) {
super(error_description);
Object.setPrototypeOf(this, GenericError.prototype);
}
}
8 changes: 3 additions & 5 deletions src/errors.tsx
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import { GenericError } from "@auth0/auth0-spa-js";

/**
* An OAuth2 error will come from the authorization server and will have at least an `error` property which will
* be the error code. And possibly an `error_description` property
*
* See: https://openid.net/specs/openid-connect-core-1_0.html#rfc.section.3.1.2.6
*/
export class OAuthError extends GenericError {
constructor(error: string, error_description?: string) {
super(error, error_description || error);
export class OAuthError extends Error {
constructor(public error: string, public error_description?: string) {
super(error_description || error);

// https://github.com/Microsoft/TypeScript-wiki/blob/master/Breaking-Changes.md#extending-built-ins-like-error-array-and-map-may-no-longer-work
Object.setPrototypeOf(this, OAuthError.prototype);
Expand Down

0 comments on commit 2ac5c94

Please sign in to comment.