Skip to content

Commit

Permalink
Workaround for failing "integration test (CRA)" (#769)
Browse files Browse the repository at this point in the history
### Description

> Currently we are unable to merge any PR to the `main` because
`integration test (CRA)` and `integration test (Gatsby)` are failing
when the Github runs checks. This issue is caused by one of the
sub-dependancy (`ajv`) update in the example app
`examples/cra-react-router`. The changes made in the pull-request serve
as a temporary workaround rather than a definitive solution.

### References
> Original issue; failing `Integration Tests / Run example tests
(pull_request_target)`.
<img width="1728" alt="image"
src="https://github.com/auth0/auth0-react/assets/167290944/33b3b279-790d-40af-9159-949dd36ffa26">


### Testing

> With this PR changes, all the integration tests and workflow checks
should get passed.

- [ ] This change adds test coverage for new/changed/fixed functionality

### Checklist

- [ ] I have added documentation for new/changed functionality in this
PR or in auth0.com/docs
- [x] All active GitHub checks for tests, formatting, and security are
passing
- [x] The correct base branch is being used, if not the default branch
  • Loading branch information
nandan-bhat authored Jun 21, 2024
1 parent 6bf58e8 commit 4ec5410
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 3 additions & 0 deletions examples/cra-react-router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"react-scripts": "^5.0.1",
"typescript": "^4.6.3"
},
"devDependencies": {
"ajv": "8.16.0"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build"
Expand Down
3 changes: 2 additions & 1 deletion examples/gatsby-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"react-dom": "file:../../node_modules/react-dom"
},
"devDependencies": {
"prettier": "2.0.5"
"prettier": "2.0.5",
"ajv": "8.16.0"
},
"keywords": [
"gatsby"
Expand Down

0 comments on commit 4ec5410

Please sign in to comment.