Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #10361

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Fix typos #10361

merged 5 commits into from
Jan 24, 2024

Conversation

BcnCarlos
Copy link
Contributor

@BcnCarlos BcnCarlos requested a review from a team as a code owner January 24, 2024 15:15
adding maui interactive page
avanscoy
avanscoy previously approved these changes Jan 24, 2024
Copy link
Contributor

@avanscoy avanscoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Comment on lines 86 to 89
},
{
from: `/quickstart/native/maui`,
to: '/quickstart/native/maui/interactive',
Copy link
Member

@frederikprijck frederikprijck Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not do this, as the non interactive version is still used in the dashboard (manage.auth0.com).

The docs platform should have a general redirect in place to redirect to the interactive when not running in manage.auth0.com.

If there is an issue with those redirects, that should be addressed at that level and not enforce a global redirect.

BcnCarlos and others added 2 commits January 24, 2024 16:50
Copy link
Contributor Author

@BcnCarlos BcnCarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated ClientId variable

@frederikprijck
Copy link
Member

Thanks for fixing that!

@BcnCarlos BcnCarlos merged commit bacd1d7 into master Jan 24, 2024
6 checks passed
@BcnCarlos BcnCarlos deleted the DR-2050-Fix-typos branch January 24, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants