-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating links in Quickstarts to open in new tab #10505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we consider adding rel="noreferrer"
?
See: https://developer.chrome.com/docs/lighthouse/best-practices/external-anchors-use-rel-noopener
When you link to a page on another site using the target="_blank" attribute, you can expose your site to performance and security issues:
I see we are adding target="_blank"
that target another site.
The page I linked also explains the solution:
Adding rel="noopener" or rel="noreferrer" to your target="_blank" links avoids these issues.
It also mentions this is mostly for legacy browsers, as modern browser solve this internally already. So I would still recommend considering it.
6f75546
to
27edab4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates approved
ce800bf
to
aed48ef
Compare
aed48ef
to
e564b81
Compare
Changes
/articles/quickstart
to<a href="link" target="_blank" rel="noreferrer">
. This will make it open in a new tab./articles/_includes
. These files are commonly used in Quickstarts (api_auth_intro.md, _callback_url.md, etc).Changes were made using this script, and manually tested in local environment to check that the links were working properly. Images in the markdown format of

were not altered.