Skip to content

Commit

Permalink
Fixed Naming Conventions For HRI Features Support (#433)
Browse files Browse the repository at this point in the history
  • Loading branch information
developerkunal authored Aug 16, 2024
1 parent b6f1206 commit 921144d
Show file tree
Hide file tree
Showing 9 changed files with 351 additions and 351 deletions.
4 changes: 2 additions & 2 deletions EXAMPLES.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,13 +200,13 @@ To handle nullable fields, create a custom struct without the omitempty tag and
```go
// Define a custom struct similar to the `Tenant` struct exposed by the SDK but without the `omitempty` tag.
type CustomTenant struct {
AcrValuesSupported *[]string `json:"acr_values_supported"`
ACRValuesSupported *[]string `json:"acr_values_supported"`
MTLS *management.MTLSConfiguration `json:"mtls"`
}

// Create a custom request to set the nullable fields to null.
nullableTenantSettings := &CustomTenant{
AcrValuesSupported: nil,
ACRValuesSupported: nil,
MTLS: nil,
}

Expand Down
6 changes: 3 additions & 3 deletions management/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ type Client struct {
OIDCLogout *OIDCLogout `json:"oidc_logout,omitempty"`

// SignedRequestObject JWT-secured Authorization Requests (JAR) settings for the client.
SignedRequestObject *SignedRequestObject `json:"signed_request_object,omitempty"`
SignedRequestObject *ClientSignedRequestObject `json:"signed_request_object,omitempty"`

// ComplianceLevel Defines the compliance level for this client, which may restrict it's capabilities
//
Expand All @@ -140,8 +140,8 @@ type Client struct {
RequireProofOfPossession *bool `json:"require_proof_of_possession,omitempty"`
}

// SignedRequestObject is used to configure JWT-secured Authorization Requests (JAR) settings for our Client.
type SignedRequestObject struct {
// ClientSignedRequestObject is used to configure JWT-secured Authorization Requests (JAR) settings for our Client.
type ClientSignedRequestObject struct {
// Indicates whether the JAR requests are mandatory
Required *bool `json:"required,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion management/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestClientSignedRequestObject(t *testing.T) {
expectedClient := &Client{
Name: auth0.Stringf("Test Client (%s)", time.Now().Format(time.StampMilli)),
Description: auth0.String("This is just a test client."),
SignedRequestObject: &SignedRequestObject{
SignedRequestObject: &ClientSignedRequestObject{
Required: auth0.Bool(true),
Credentials: &[]Credential{
{
Expand Down
Loading

0 comments on commit 921144d

Please sign in to comment.