Add strategy_version support to required connections in Connection Manager
#443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
==========================================
+ Coverage 95.67% 95.71% +0.03%
==========================================
Files 49 49
Lines 8187 8207 +20
==========================================
+ Hits 7833 7855 +22
+ Misses 237 235 -2
Partials 117 117 ☔ View full report in Codecov by Sentry. |
acwest
force-pushed
the
ESD-39527-add-strategy-version-to-connections
branch
from
6456be6 to
6184484
Compare
developerkunal
changed the title
strategy_version support to required connections in Connection Manager
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Add the
strategy_versionoption to the Connection types which should support it, but currently don't.These include:
ConnectionOptionsOAuth2(for Paypal)ConnectionOptionsADConnectionOptionsAzureADConnectionOptionsADFSConnectionOptionsSAML📚 References
🔬 Testing
📝 Checklist