Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH: Rename user_id_attribute to userid_attribute in Azure Connection Options #454

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Oct 14, 2024

🔧 Changes

  • This patch renames the user_id_attribute JSON field to userid_attribute in the Azure Connection Options struct.

📚 References

N/A

🔬 Testing

  • A test case was added to verify that valid values for userid_attribute are correctly passed and processed.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner October 14, 2024 12:03
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (ac45d81) to head (6f45863).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          51       51           
  Lines        8461     8461           
=======================================
  Hits         8107     8107           
  Misses        236      236           
  Partials      118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@developerkunal developerkunal changed the title PATCH: Update attribute name to userid_attribute in Azure Connection Options PATCH: Rename user_id_attribute to userid_attribute in Azure Connection Options Oct 14, 2024
@developerkunal developerkunal merged commit e3b7816 into main Oct 14, 2024
9 checks passed
@developerkunal developerkunal deleted the Fix/attribute_name_connection_options branch October 14, 2024 12:35
@developerkunal developerkunal mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants