-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support For Global Token Revocation To SAML Connections in ConnectionManager
#491
Add Support For Global Token Revocation To SAML Connections in ConnectionManager
#491
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 95.47% 95.48%
=======================================
Files 56 56
Lines 10926 10936 +10
=======================================
+ Hits 10432 10442 +10
Misses 373 373
Partials 121 121 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to add a Jira ID on the branch name; helps for better tracking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add example regarding the PR
🔧 Changes
ConnectionManager
.ConnectionOptionsSAML
:GlobalTokenRevocationJWTIss *string json:"global_token_revocation_jwt_iss,omitempty"
GlobalTokenRevocationJWTSub *string json:"global_token_revocation_jwt_sub,omitempty"
Example Usage:
📚 References
🔬 Testing
📝 Checklist