Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting captcha_widget_theme in BrandingTheme Struct in BrandingThemeManager #492

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

duedares-rvj
Copy link
Member

@duedares-rvj duedares-rvj commented Jan 30, 2025

🔧 Changes

  • Added support for setting captcha_widget_theme in BrandingTheme.
  • Introduced a new field in the BrandingTheme struct:
    CaptchaWidgetTheme string `json:"captcha_widget_theme"`
  • This field has been added under BrandingThemeColors in BrandingThemeManager.
  • Allows customization of the Captcha widget theme for branding.

📚 References

🔬 Testing

  • Ensure the captcha_widget_theme field is correctly serialized/deserialized in the BrandingTheme struct.
  • Validate that updating the branding theme successfully applies the Captcha widget theme customization.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner January 30, 2025 18:28
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (553f3e5) to head (4b656bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          56       56           
  Lines       10921    10921           
=======================================
  Hits        10427    10427           
  Misses        373      373           
  Partials      121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@developerkunal developerkunal changed the title Add support to set captcha_widget_theme for branding theme Add support for setting captcha_widget_theme in BrandingTheme Struct in BrandingThemeManager Feb 3, 2025
@developerkunal developerkunal merged commit 92ee81d into main Feb 3, 2025
7 checks passed
@developerkunal developerkunal deleted the captcha_widget_theme branch February 3, 2025 07:22
@duedares-rvj duedares-rvj self-assigned this Feb 5, 2025
@developerkunal developerkunal mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants