-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for FCMv1 Server Credentials
in MultiFactorPush
Sub-Manager of GuardianManager
#512
Conversation
Hi @chrisnellis, I hope you're doing well! Thank you for opening the PR. Could you please sign your commits as well? We have a new policy requiring this, and I’ll be updating the contribution guide accordingly. I'll review the PR, and if needed, I can make changes as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 57 57
Lines 11267 11276 +9
=======================================
+ Hits 10773 10782 +9
Misses 373 373
Partials 121 121 ☔ View full report in Codecov by Sentry. |
FCMv1 Server Credentials
in MultiFactorPush
Manager
Hi @chrisnellis, I've added the test recordings and verified them. I also noticed the getters were missing—we use the The only thing left is signing the commits. Once that’s done, we should be good to go! Thank you for your contribution. 🚀 |
FCMv1 Server Credentials
in MultiFactorPush
ManagerFCMv1 Server Credentials
in MultiFactorPush
Sub-Manager of GuardianManager
Thanks, @developerkunal I signed and rebased the commits and re-pushed. Please review at your leisure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Very good. Thank you for the help getting this merged! I eagerly await the next release so I can start to add Terraform support for this field |
🔧 Changes
Auth0 Guardian API – Update FCMv1 Credentials
📚 References
🔬 Testing
📝 Checklist
First-time contributor—happy to make any modifications as needed! 😊